[#1144] Standardize the API error envelope - #1160
Merged
greatest0fallt1me merged 1 commit intoAug 27, 2026
Merged
Conversation
4 tasks
Contributor
|
Before merge, please complete the missing #1144 requirements: define the versioned error-envelope/OpenAPI mappings and add explicit contract coverage for the required auth, validation, conflict, rate-limit, and upstream failure responses. The current diff centralizes handling but does not update the documented API mappings or demonstrate all required failure classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavior
Validation
npm test -- --runInBand src/errors/errorEnvelopePolicy.test.ts src/middleware/errorHandler.contract.test.ts src/middleware/envelope.error-contract.test.tsnpm run typecheck(blocked by the pre-existing syntax errors insrc/routes/refresh-token.test.ts:445)Closes #1144